Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when an expression such as if returns a result, return the resul… #145

Merged
merged 2 commits into from
Feb 19, 2024
Merged

fix: when an expression such as if returns a result, return the resul… #145

merged 2 commits into from
Feb 19, 2024

Conversation

KKould
Copy link
Member

@KKould KKould commented Feb 19, 2024

What problem does this PR solve?

fix: when an expression such as if returns a result, return the result as the expected type

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Feb 19, 2024
@KKould KKould added the invalid This doesn't seem right label Feb 19, 2024
@KKould KKould merged commit 7d4e549 into KipData:main Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@KKould KKould

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KKould